fix(storybook): fix broken PageSecondaryEmailAdd and PageChangePassword stories#20425
Merged
vpomerleau merged 1 commit intomainfrom Apr 21, 2026
Merged
fix(storybook): fix broken PageSecondaryEmailAdd and PageChangePassword stories#20425vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes two broken Storybook stories in fxa-settings by ensuring pages that rely on AppContext hooks are rendered with an AppContext.Provider.
Changes:
- Add
AppContext.ProvideraroundPageSecondaryEmailAddstory rendering. - Add
AppContext.ProvideraroundPageChangePasswordstory rendering (usingmockAppContext()).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/fxa-settings/src/components/Settings/PageSecondaryEmailAdd/index.stories.tsx | Wraps the story in AppContext.Provider using mockAppContext() so hooks like useAccount() don’t throw. |
| packages/fxa-settings/src/components/Settings/PageChangePassword/index.stories.tsx | Wraps the story in AppContext.Provider using mockAppContext() so hooks like useAccount() don’t throw. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vbudhram
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.