chore(sentry): remove unused @nestjs/apollo, @nestjs/graphql, @apollo/server#20452
Merged
vpomerleau merged 1 commit intomainfrom May 5, 2026
Merged
chore(sentry): remove unused @nestjs/apollo, @nestjs/graphql, @apollo/server#20452vpomerleau merged 1 commit intomainfrom
vpomerleau merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dead GraphQL/Apollo-related Sentry integration code and dependencies now that GraphQL runtime surfaces have been retired from the monorepo, reducing upgrade scope (notably for the NestJS 11 lockstep) and eliminating the need for the pending Apollo Server dependency bump.
Changes:
- Delete the unused Nest/Apollo
SentryPluginand stop exporting it from@fxa/shared/sentry. - Remove GraphQL/Apollo-specific error handling branches (
isApolloError,processException) from Sentry reporting helpers (and associated unit tests). - Drop
@apollo/server,@nestjs/apollo, and@nestjs/graphqlfrom root dependencies and prune the lockfile accordingly.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes Apollo Server / Nest GraphQL transitive dependency entries after dependency cleanup. |
| package.json | Drops unused GraphQL server-side dependencies from root dependencies. |
| libs/shared/sentry/src/lib/reporting.ts | Removes Apollo/GraphQL-specific ignore/reporting helpers and related imports. |
| libs/shared/sentry/src/lib/reporting.spec.ts | Deletes the “ignore apollo errors” test and GraphQLError import. |
| libs/shared/sentry/src/lib/nest/sentry.plugin.ts | Deletes the unused Apollo Server Sentry plugin implementation. |
| libs/shared/sentry/src/index.ts | Removes barrel export for the deleted Sentry plugin. |
| libs/shared/sentry-nest/src/lib/reporting.ts | Removes Apollo/GraphQL-specific helpers/branches from Nest Sentry reporting utilities. |
| libs/shared/sentry-nest/src/lib/reporting.spec.ts | Deletes the “ignore apollo errors” test and GraphQLError import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vbudhram
reviewed
Apr 27, 2026
…/server Because: - fxa-graphql-api was retired and fxa-admin-server/admin-panel migrated from GraphQL to REST, so nothing in the monorepo reaches @nestjs/apollo, @nestjs/graphql, or @apollo/server at runtime. - The only remaining surface was three stale Sentry integration files: a SentryPlugin class with zero importers and two dead `graphql` context branches in the reporting helpers. - Dropping them shrinks the NestJS 11 lockstep upgrade scope (FXA-13358), obsoletes dependabot PR #20275 (@apollo/server 4 → 5), and eliminates five related advisories including GHSA-9q82-xgwf-vj6h. This commit: - Deletes libs/shared/sentry/src/lib/nest/sentry.plugin.ts and its barrel export. - Strips @nestjs/graphql and @apollo/server imports, isApolloError, and processException from reporting.ts in both libs/shared/sentry and libs/shared/sentry-nest, and removes the isApolloError call from ignoreError. - Removes the "should ignore apollo errors" test and GraphQLError import from both reporting.spec.ts files. - Removes @apollo/server, @nestjs/apollo, and @nestjs/graphql from the root package.json and the corresponding yarn.lock entries. - Drops '@nestjs/apollo' and '@nestjs/graphql' from the serverExternalPackages array in apps/payments/next/next.config.js since those packages no longer resolve. - Pins @types/node-fetch ^2.6.12 as a direct root devDependency — @apollo/server was transitively providing it, and packages/fxa-admin-server/src/newsletters/basket.service.ts still imports from node-fetch. - Migrates libs/vendored/jwtool/src/lib/jwtool.ts to Node 22's global fetch (typed via @types/node/globals.d.ts) so the vendored library no longer imports node-fetch. Closes #FXA-13606
vbudhram
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
@nestjs/apollo,@nestjs/graphql, or@apollo/serverat runtime.SentryPluginclass with zero importers and two deadgraphqlcontext branches in the reporting helpers.@apollo/server4 → 5), and eliminates five related advisories including GHSA-9q82-xgwf-vj6h.This pull request
libs/shared/sentry/src/lib/nest/sentry.plugin.tsand its barrel export.@nestjs/graphqland@apollo/serverimports,isApolloError, andprocessExceptionfromreporting.tsin bothlibs/shared/sentryandlibs/shared/sentry-nest, and removes theisApolloErrorcall fromignoreError.GraphQLErrorimport from bothreporting.spec.tsfiles.@apollo/server,@nestjs/apollo, and@nestjs/graphqlfrom rootpackage.jsonand the correspondingyarn.lockentries.'@nestjs/apollo'and'@nestjs/graphql'from theserverExternalPackagesarray inapps/payments/next/next.config.jssince those packages no longer resolve.@types/node-fetch^2.6.12 as a direct root devDependency —@apollo/serverwas transitively providing it, andpackages/fxa-admin-server/src/newsletters/basket.service.tsstill imports fromnode-fetch.libs/vendored/jwtool/src/lib/jwtool.tsto Node 22's globalfetch(typed via@types/node/globals.d.ts) so the vendored library no longer importsnode-fetch.Issue that this pull request solves
Closes: FXA-13606
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.