chore(metrics): de-categorise content server perf events#2574
Merged
Conversation
Historically we divided content server performance events into two categories, "auth" and "other". That was useful for viewing agggregate performance at the start of our funnels, but got in the way of other analysis. This change ditches those categories and just uses the raw view names instead. If we need to categorise events, we can do that in bespoke queries in Redash.
philbooth
force-pushed
the
pb/uncategorised-perf-events
branch
from
1743fea to
c1ea6c0
Compare
This was referenced Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #662 (comment).
Historically we divided content server performance events into two categories,
authandother. That was useful for viewing agggregate performance at the start of our funnels, but got in the way of other analysis. This change ditches those categories and just uses the raw view names instead. If we need to categorise events, we can do that in bespoke queries in Redash.Opened speculatively in response to the linked comment above. If we land it, we'll also need to update the queries for the perf dashboard.
@mozilla/fxa-devs r?