Restore product from receipt (bug 981235)

[kumar303]

No description provided.

[mstriemer]

Is there any documentation on what the info object is? Is it just an object with a productId?

[kumar303]

It just has productId for now but I would like to document the info object. I should add that to the docs.

[mstriemer]

r+wc

Still not crazy about node-style callbacks though. It might be nice for oninit to be passed an array of receipts but that could be handled later.

Weird suggestion for the possibly future promises: use forEach for onrestore. I don't think that's a convention in JS but we should make it one.

fxpay.init().forEach(function (receipt) {
    // Do stuff.
}).done(function (receipts) {
    // Got all of them!
}).fail(function (error) {
    // Oops.
});

[kumar303]

I think moving to promises might be worthwhile.

As for passing a restoration callback an array of products (or receipts), I thought about this and I don't think it's practical. I think you'd want one callback per product so that you can enable/disable each one independently of the others. Also, the forEach...fail suggests that one failure would abort all other receipt checks, including valid ones. I still lean toward one callback per product.

[kumar303]

The thing I like about node style callbacks is you don't have to define a separate error callback. It seems more concise. Also, it forces the caller to at least think about errors.

[mstriemer]

r+