Merged
Conversation
mdboom
force-pushed
the
fix-spellcheck
branch
from
51c8759 to
f97ad46
Compare
mdboom
commented
Feb 19, 2020
| @@ -1,8 +1,8 @@ | |||
| This directory contains a tool to analyse the patterns of baseline and metrics pings received on a per-client basis in Fenix. These pattern analyses are then summarized in a single plot showing various patterns and issues found in the data. | |||
| This directory contains a tool to analyze the patterns of baseline and metrics pings received on a per-client basis in Fenix. These pattern analyses are then summarized in a single plot showing various patterns and issues found in the data. | |||
badboy
approved these changes
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the spellchecker to run on all of the markdown files checked into git (except DEPENDENCIES.md).
This fixes a minor bug with the spellcheck script so it will always spellcheck the CHANGELOG.
The issue is that when the docs are built,
./CHANGELOG.mdis copied todocs/appendix/changelog.md. The spellcheck script only looked at.mdin thedocsdirectory, so the changelog would be spellchecked only if the developer had previously built the docs. Notably, it meant theCHANGELOG.mdwas not spellchecked on CI. This should at least keep things consistent, and not force users to spellcheck things in the CHANGELOG that were previously missed by CI.