Skip to content

Spellcheck all the things #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 1 commit into from
Feb 20, 2020
Merged

Spellcheck all the things #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .dictionary
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
personal_ws-1.1 en 142 utf-8
personal_ws-1.1 en 151 utf-8
AAR
AARs
APIs
Expand All @@ -11,6 +11,7 @@ CMake
CODEOWNERS
Cartfile
CircleCI
Ciufo
Datetime
Datetimes
Fenix
Expand Down Expand Up @@ -44,9 +45,11 @@ PowerShell
ProGuard
Protobufs
PyPI
Redash
SDK
TODO
TWiG
Taskcluster
UI
URIs
UTF
Expand All @@ -70,10 +73,13 @@ chutten
cmd
codecov
codepoints
commandline
conda
coroutine
csh
dataset
destructor
dev
dexter
distributable
docstrings
Expand All @@ -86,6 +92,7 @@ experimentId
ffi
func
gfritzsche
glinter
gradle
grcov
hotfix
Expand Down Expand Up @@ -114,6 +121,7 @@ pidcat
pipenv
pre
prebuilt
preinit
py
pytest
rkv
Expand All @@ -133,6 +141,7 @@ timespans
timezones
toolchain
toolchains
tooltip
transpiler
travis
unhandled
Expand Down
2 changes: 1 addition & 1 deletion bin/spellcheck.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ aspell --version
shopt -s nullglob

dict_filename=./.dictionary
markdown_sources="$(find ./docs -name '*.md')"
markdown_sources="$(git ls-files | grep -v 'DEPENDENCIES\.md' | grep '\.md$')"
mode="check"
aspell_args="--lang en_US --mode=markdown"

Expand Down
2 changes: 1 addition & 1 deletion samples/ios/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
A minimal example showcasing the integration of Glean into an iOS application.
This app does nothing, but enable Glean.

Glean sends a [`baseline`][] ping when the app is backgrounded.
Glean sends a [`baseline`][] ping when the app is sent to background.

[`baseline`]: https://mozilla.github.io/glean/book/user/pings/baseline.html

Expand Down
6 changes: 3 additions & 3 deletions tools/analysis/ping-patterns/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
This directory contains a tool to analyse the patterns of baseline and metrics pings received on a per-client basis in Fenix. These pattern analyses are then summarized in a single plot showing various patterns and issues found in the data.
This directory contains a tool to analyze the patterns of baseline and metrics pings received on a per-client basis in Fenix. These pattern analyses are then summarized in a single plot showing various patterns and issues found in the data.
Copy link
Copy Markdown
Contributor Author

@mdboom mdboom Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇨🇦 -> 🇺🇸


## Requirements

A recent version of [matplotlib](https://matplotlib.org).
A recent version of [`matplotlib`](https://matplotlib.org).

## Collecting input data

Expand Down Expand Up @@ -66,6 +66,6 @@ Baseline pings are in blue. The thick part of the line represents the active se

Metrics pings are in red. Issues found with metrics pings are notated with a number to the right. Hover over the number to display a tooltip with further information about the issue.

Grey vertical lines are midnight local time. Dashed grey vertical lines are 04:00 local time.
Gray vertical lines are midnight local time. Dashed gray vertical lines are 04:00 local time.

Green vertical lines indicate the first ping coming from an interesting revision that contains a related fix.