[bug 989115] Implemented simple wiki landing page for configured locales#2145
[bug 989115] Implemented simple wiki landing page for configured locales#2145rlr merged 1 commit intomozilla:masterfrom
Conversation
rlr
force-pushed
the
faq-locales-989115
branch
from
ec1efa7 to
48892f7
Compare
|
OK. This is ready with the right settings for shipping now. ☝️ |
There was a problem hiding this comment.
I think you can put this decorator on the class if you want to.
|
Travis 💣 |
There was a problem hiding this comment.
You're checking for the wrong url here.
There was a problem hiding this comment.
oh right. I changed that in the last commit. #fail
|
❤️ travis |
|
Besides the test failure, this seems fine to me. I checked on the site, and none of these locales have any content on the FAQ yet. I'm not sure if we want to save to land this with the settings right now considering that. |
|
fixes 👆 Yeah. I'm going to wait for green light from the L10n boss. |
|
Cool. Code is r+. |
rlr
force-pushed
the
faq-locales-989115
branch
from
45c3cd9 to
54fedec
Compare
|
rebased against master. still waiting for green light. le sigh |
|
I see green. 🚢 |
|
Oh, oops. I thought you meant green from Travis, not from L10n boss. Nevermind. |
rlr
force-pushed
the
faq-locales-989115
branch
2 times, most recently
from
470465d to
c2db4a2
Compare
|
rebased and limited to only estonian (et). I'll land as soon as Travis is cool. |
rlr
force-pushed
the
faq-locales-989115
branch
from
c2db4a2 to
66a43dd
Compare
|
66a43dd [bug 989115] Implemented simple wiki landing page for configured locales |
2 participants
I implemented a decorator that requests certain configured locales to be redirected to a configured kb page. The settings still aren't set (waiting for the info) but the actual code is ready to go I think.
To test:
r?