[bug 775231] Migrate tags to products#743
Closed
willkg wants to merge 1 commit into
Closed
Conversation
* migration for connecting documents with appropriate products from the new products table * updated kb forms so they work with the new products stuff * updated tests
Contributor
|
I haven't finished my coffee yet, but this looks good. I'll give it a run and another look once i have moar coffee in my blood. |
Member
Author
|
It's probably worth spending the extra time to make sure I didn't miss something---you know this system much better than I do. Screwing things up here probably puts us in a fire-fighting mode for a couple of days. Having said that, since we're not deleting tags, this is way safer. That was a fab idea. |
Contributor
|
Yeah seriously, this looks good and is working for me, tests pass, migration worked, etc. Just those two mentions of topic instead of product ;). Once this lands, I'll rebase my search branch on top and go through the comments. |
Member
Author
|
Landed in ae09810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new products table
Pretty sure this covers everything. I'm a little fuzzy on the "if the doc has a parent, then don't save the products" bit. I'm not entirely sure I understand that requirement or that it's correctly coded in the new system.
Everything else should be ok for now, though.
r?