fix favicon on Firefox for Android#7461
Merged
Merged
Conversation
escattone
changed the title
akatsoulas
approved these changes
May 6, 2026
| # This is using our JS-style string formatting. | ||
| response[locale] = { | ||
| "suggestion": _("Would you like to view this page in " "%(language)s instead?"), | ||
| "suggestion": _("Would you like to view this page in %(language)s instead?"), |
Collaborator
There was a problem hiding this comment.
This introduces a bit of scope creep. The change is subtle so probably is OK this time but we should avoid this
| """A wrapper around django.views.static.serve that adds CORS headers.""" | ||
| if not settings.DEBUG: | ||
| raise RuntimeError("Don't use kitsune.sumo.views.serve_cors " "in production.") | ||
| raise RuntimeError("Don't use kitsune.sumo.views.serve_cors in production.") |
Collaborator
There was a problem hiding this comment.
Similar comment with the previous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2889
This is another attempt to fix the favicon for SUMO on Firefox for Android. It also ensures that all of our favicons are the same and satisfy the brand guidelines.
Rationale
The previous markup gave Fenix two broken candidates:
type="image/x-icon") — Fenix's icon parser de-prioritizes ICO on Android, so it tended to skip it.With both candidates failing, Fenix had nothing to display.
The fix:
Now Fenix has a clean primary candidate and consistent fallbacks.
Caveat: Fenix caches favicons aggressively, so post-deploy verification should use a fresh profile or cleared site data.