[bug 818908] Fix ValueError#998
Closed
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:value-error-fix-818908
Closed
[bug 818908] Fix ValueError#998willkg wants to merge 1 commit intomozilla:masterfrom willkg:value-error-fix-818908
willkg wants to merge 1 commit intomozilla:masterfrom
willkg:value-error-fix-818908
Conversation
product.get('products') can return None in the Sync and Other product
cases and then Django gets fussy. This tweaks that so that we only
apply the filter if product has a products list.
Also, I fixed 3 pep-8 issues.
Contributor
|
Looks good! Thanks for the code style fixes as well! r+ |
Member
Author
|
Landed in f11c6b0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
product.get('products') can return None in the Sync and Other product
cases and then Django gets fussy. This tweaks that so that we only
apply the filter if product has a products list.
Also, I fixed 3 pep-8 issues.
@rlr Can you look this over and make sure it's ok? I'm pretty sure this is correct, but you wrote that code and would know better. r?