Preview changes bug 755019

[groovecoder]

No description provided.

[lmorchard]

Dug out from under my kumascript pile, going to peek at this

[lmorchard]

Test pass, so far so good

[lmorchard]

Seeing an encoding issue, trying to trace it down. This document source saves and renders (mostly) fine, but on preview gets a error from kumascript of "Unexpected token &":

<div class="noinclude">
  {{ XULRefAttr() }}</div>
<dl>
  <dt>
    {{ XULAttr(&quot;cols&quot;) }}</dt>
  <dd>
    Type: <em>integer</em></dd>
  <dd>
    I like pies. For multiline textboxes, the number of columns to display.</dd>
</dl>
<div class="noinclude">
  <p>{{ languages( { &quot;de&quot;: &quot;de/XUL/Attribute/cols&quot;, &quot;ja&quot;: &quot;ja/XUL/Attribute/cols&quot; } ) }}</p>
</div>
<p>&nbsp;</p>

The weird thing is that a GET of the saved doc with a ?raw parameter comes up with all the "'s as ", so I'm not sure where the HTML escaping / unescaping happens. I think ckeditor inserts the "'s, but something somewhere else turns them back to "'s

Update: Looks like the content POSTed to the preview_revision view has "'s in kumascript macros, which causes the syntax error. (eg. This is invalid syntax: {{ XULAttr("cols") }}) Now, why the GET of ?raw content doesn't have that HTML encoding, I can't remember.

[groovecoder]

CKEDITOR's getData() does html processing; I fixed this by using CKEDITOR's getSnapshot() instead.

But, I ran into another issue:

TypeError: Parameter 'url' must be a string, not undefined
    at Object.urlParse [as parse] (url.js:92:11)
    at [object Object].<anonymous> (/vagrant/kumascript/lib/kumascript/api.js:99:26)
    at /vagrant/kumascript/lib/kumascript/api.js:109:33
    at Object.callback (/vagrant/kumascript/lib/kumascript/api.js:283:17)

Looks like kumascript wants a url environment variable to determine baseUrl. Should we try change kumascript so url isn't required, or can I pass in the doesn't-exist-yet url?

[groovecoder]

Have to send a url - even if it's just to / in case the kumascript tries to include other templates.

[groovecoder]

So this should be fixed now and ready for merge.