Bug 1247894 - add about:loop* URL definitions to add-on

[dmose]

No description provided.

[Standard8]

Rather than doing the eslint-disable-line, lets just add AboutLoop to the add-on/chrome/.eslintrc like we've done with our other modules.

[dmose]

OK, so, here's an updated version. It might or might not be right. Stuff that's going on:

Running against a normal nightly:

• typing about:looppanel in a tab shows nothing, as well as no errors in the console
• typing about:loopconversation in a tab shows this:

[Exception... "newChannel requires at least one of the 'loadingNode', 'loadingPrincipal', or 'loadUsingSystemPrincipal' properties on the options object." nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/RemoteAddonsParent.jsm :: AboutProtocolParent.openChannel :: line 268" data: no]
AboutProtocolParent.openChannel()
RemoteAddonsParent.jsm:268
AboutProtocolParent.receiveMessage()
RemoteAddonsParent.jsm:235
TypeError: can't convert undefined to object (RemoteAddonParent.jsm:258:9)

Taking gecko-dev, I then applied your patch to remove the old URLs (though I'm not actually convinced it removes them completely, based on the behavior seen when loading them in tabs with the in-gecko-dev copy of the add-on).

Doing a make exportc_mc, rebuilding, and starting up with mach run first spews this warning:

1462508352283 addons.xpi WARN Problem getting last modified time for /Users/dmose/r/gecko-dev/obj-ff-dbg/dist/NightlyDebug.app/Contents/Resources/browser/features/loop@mozilla.org/chrome/content/shared/js/models.js: [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.lastModifiedTime]" nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)" location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: recursiveLastModifiedTime :: line 1911" data: no] Stack trace: recursiveLastModifiedTime()@resource://gre/modules/addons/XPIProvider.jsm:1911

which suggests the models location move did not get properly adjusted in the export. I haven't had a chance to poke at this.

Then, about:looppanel behaves reasonably, both in a tab, as well as in the drop-down.

Starting a convo using the drop-down panel, however, doesn't work (the panel doesn't close), but this (possibly unrelated) shows up in the console:

NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) nsIIOService2.newURI

However, restarting with the about:config interposition pref forced to false does somewhat better. So there's something shim-my going on here...

[Standard8]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.