Bug 1261488 - ToC & sidebar proto-impl (rebased & unforked)#376
Bug 1261488 - ToC & sidebar proto-impl (rebased & unforked)#376dmose merged 18 commits intomozilla:akitafrom
Conversation
mancas
changed the title
|
Interestingly, when I run |
|
Also, the UI-showcase is in relatively bad shape (a lot of views are broken). I suspect this doesn't want to block landing, but probably does want to be one of the first things we fix post-landing. |
| // unregister about: handlers | ||
| AboutLoop.conversation.unregister(); // eslint-disable-line no-undef | ||
| AboutLoop.panel.unregister(); // eslint-disable-line no-undef | ||
| AboutLoop.toc.unregister(); // eslint-disable-line no-undef |
There was a problem hiding this comment.
Hmm, I think this was mentioned in Mark's original review comments. Do we still need to go through and address his original comments now that we've unforked?
There was a problem hiding this comment.
I can't see the comment you're talking about
There was a problem hiding this comment.
Yeah, I got confused; never mind!
mancas
force-pushed
the
unforked-toc-sidebar-prototype-1261762
branch
from
b3b7f82 to
7522eb5
Compare
|
I did squash of the latests commits to get the unit tests stuff all together in one commit |
mancas
force-pushed
the
unforked-toc-sidebar-prototype-1261762
branch
from
7522eb5 to
01e405b
Compare
| sidebarBrowser.setAttribute("disable-global-history", "true"); | ||
|
|
||
| // XXX something like these seem likely to be required once we | ||
| // electrolyze this along with a URI_MUST_LOAD_IN_CHILD in |
There was a problem hiding this comment.
The sidebar is already URI_MUST_LOAD_IN_CHILD. I think this probably doesn't apply, however, lets change the XXX to XXX akita and verify it before too much longer.
Actually I think having the must load in child forces it into a remote browser, but specifying the browser element remote by default optimises the process.
So just update the XXX for now please.
mancas
force-pushed
the
unforked-toc-sidebar-prototype-1261762
branch
from
01e405b to
1f2b5f5
Compare
dmose
force-pushed
the
unforked-toc-sidebar-prototype-1261762
branch
from
1f2b5f5 to
5dfefab
Compare
…View, r=Standard8
…versation, r=Standard8
3 participants
This is the first part of doing the unforking and untangling that @Standard8 requested in his review of #329.