feat: add DevTools plugin gated to cloud-engineering/admins#130
Merged
Conversation
…n policy Replaces the allow-all permission policy with DevToolsAdminPermissionPolicy, which allows every permission except the four DevTools permissions, which now require the caller's ownership refs to include group:workgroups/cloud-engineering-admin. Removes the now-unused @backstage/plugin-permission-backend-module-allow-all-policy dependency.
…admin-permission # Conflicts: # packages/backend/package.json # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Backstage DevTools plugin (frontend page + backend) and restricts it
to members of the
cloud-engineering/adminsworkgroup subgroup via a custompermission policy.
@backstage/plugin-devtools-backend; a customPermissionPolicy(
permissionPolicyDevToolsAdmin) replacing the allow-all policy — returns ALLOWfor everything except DevTools permissions, which require
group:workgroups/cloud-engineering-adminsin the caller'sownershipEntityRefs.Gates the stable
devToolsPermissionsaggregate plus the alphaScheduled-Tasks permissions.
@backstage/plugin-devtools(new frontend system) added to thefeatures array; a
RequirePermission-gated sidebar entry (hidden for non-admins).devTools.scheduledTasks.plugins: [catalog]to surface the catalogplugin's scheduled tasks.
Depends on
Account-linking (#129, merged) — that work is what makes a signed-in
cloud-engineering/adminsmember'sownershipEntityRefsactually contain thegroup, so the gate can pass. Without it the gate is inert.
Notes
.backstage/scheduler/v1/tasksAPI, which isn't permission-integrated in thepinned versions — the gate there is frontend/defense-in-depth, not a hard lock.
wip:commit).Verification
Backend policy unit tests (14) green;
tsc, lint, prettier clean. Merged currentmain(incl. account-linking) into the branch.