This repository was archived by the owner on Apr 3, 2019. It is now read-only.
bug 932703 - clean hash utm variables after track#19
Merged
groovecoder merged 1 commit intomozilla:masterfrom Mar 6, 2014
Merged
bug 932703 - clean hash utm variables after track#19groovecoder merged 1 commit intomozilla:masterfrom
groovecoder merged 1 commit intomozilla:masterfrom
Conversation
themes/Hacks2013/header.php
Outdated
Contributor
There was a problem hiding this comment.
Need to add _gaq.push(['_setAllowAnchor', true]); before this so GA will use hashes instead of a query string.
Member
Author
|
Updated. |
Member
Author
|
ping @craigcook and @darkwing - either of you able to spot-check this? |
Member
Author
|
ping @craigcook and @darkwing again here ... |
Contributor
|
Looks good to me, though I can't verify that the tracking still works properly. We can test that once it's on dev or stage. r+! 🐱 |
groovecoder
added a commit
that referenced
this pull request
Mar 6, 2014
bug 932703 - clean hash utm variables after track
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test, visit http://hacks-local.allizom.org/#utm_source=StackOverflow&utm_medium=forums&utm_campaign=StackOverflowForums - the GA call should complete successfully, and then the window location should change to http://hacks-local.allizom.org/