Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Weird Wrapping#883

Closed
wraybowling wants to merge 4 commits intomozilla:masterfrom
caktus:970697-weird-wrap
Closed

Weird Wrapping#883
wraybowling wants to merge 4 commits intomozilla:masterfrom
caktus:970697-weird-wrap

Conversation

@wraybowling
Copy link

Fixes Bug 970697
https://bugzilla.mozilla.org/show_bug.cgi?id=970697

Not a bullet-proof solution, but more what Dave Hylands [:dhylands] was asking for

@Sancus
Copy link
Contributor

Sancus commented Apr 9, 2014

Is it just me, or does this mess up the whole layout? When I have this PR checked out, the logged in homepage looks like the right column is wrapping down underneath the left column instead of having them side by side...?

@wraybowling
Copy link
Author

@Sancus you are correct. I have another few commits from this week that try to fix this but they aren't ready yet. Hope to push something soon.

@wraybowling
Copy link
Author

I think I got it working right again. A rebase may have messed me up somewhere along the way. Let me know if you find anything weird. ~ if not we'll squash.

@glogiotatidis
Copy link
Contributor

Unfortunately I don't think that this will work either:
mozillians foo bar 2014-04-15 18-24-53

Like I said in the bug I believe that the right column should go away and it's contents should be moved to the center or left column. I created a pull request #902 moving the websites to the center column. What do you think @wraybowling ?

@wraybowling
Copy link
Author

@glogiotatidis I had a look at #902 and I really like it!

@Sancus
Copy link
Contributor

Sancus commented Apr 15, 2014

Closing this in favor of #902.

@Sancus Sancus closed this Apr 15, 2014
@wraybowling wraybowling deleted the 970697-weird-wrap branch April 15, 2014 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants