Multifeature support in Desktop and Mobile including Legacy Desktop #185
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| { | ||
| "appId": "org.mozilla.firefox", | ||
| "appName": "fenix", | ||
| "application": "org.mozilla.fenix", | ||
| "arguments": {}, | ||
| "branches": [ | ||
| { | ||
| "features": [ | ||
| { | ||
| "enabled": false, | ||
| "featureId": "fenix-default-browser", | ||
| "value": {} | ||
| }, | ||
| { | ||
| "enabled": true, | ||
| "featureId": "homescreen", | ||
| "value": { | ||
| "sections-enabled": { | ||
| "jumpBackIn": false, | ||
| "pocket": false, | ||
| "recentExplorations": false, | ||
| "recentlySaved": false, | ||
| "topSites": true | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "control" | ||
| }, | ||
| { | ||
| "features": [ | ||
| { | ||
| "enabled": true, | ||
| "featureId": "fenix-default-browser", | ||
| "value": {} | ||
| }, | ||
| { | ||
| "enabled": true, | ||
| "featureId": "homescreen", | ||
| "value": { | ||
| "sections-enabled": { | ||
| "jumpBackIn": true, | ||
| "pocket": true, | ||
| "recentExplorations": true, | ||
| "recentlySaved": true, | ||
| "topSites": true | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "default_browser_newtab_banner" | ||
| } | ||
| ], | ||
| "bucketConfig": { | ||
| "count": 10000, | ||
| "namespace": "firefox-android-multifeature-test", | ||
| "randomizationUnit": "nimbus_id", | ||
| "start": 0, | ||
| "total": 10000 | ||
| }, | ||
| "channel": "nightly", | ||
| "endDate": null, | ||
| "featureIds": ["fenix-default-browser", "homescreen"], | ||
| "id": "firefox-android-multifeature-test", | ||
| "isEnrollmentPaused": false, | ||
| "outcomes": [ | ||
| { | ||
| "priority": "secondary", | ||
| "slug": "default-browser" | ||
| } | ||
| ], | ||
| "probeSets": [], | ||
| "proposedDuration": 28, | ||
| "proposedEnrollment": 7, | ||
| "referenceBranch": "control", | ||
| "schemaVersion": "1.6.2", | ||
| "slug": "firefox-android-multifeature-test", | ||
| "startDate": "2021-11-01", | ||
| "targeting": "true", | ||
| "userFacingDescription": "firefox-android-multifeature-test", | ||
| "userFacingName": "firefox-android-multifeature-test" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| { | ||
| "appId": "firefox-desktop", | ||
| "appName": "firefox_desktop", | ||
| "application": "firefox-desktop", | ||
| "arguments": {}, | ||
| "branches": [ | ||
|
There was a problem hiding this comment. Do desktop experiments not use the feature key anymore? If they will not, can older single feature experiments be affected by this?
Contributor
Author
There was a problem hiding this comment. Yep, should definitely have the |
||
| { | ||
| "feature": { | ||
| "featureId": "unused-feature-id-for-legacy-support", | ||
| "enabled": false, | ||
| "value": {} | ||
| }, | ||
| "features": [ | ||
| { | ||
| "enabled": true, | ||
| "featureId": "pocketNewtab", | ||
| "value": {} | ||
| }, | ||
| { | ||
| "featureId": "upgradeDialog", | ||
| "value": { | ||
| "enabled": false | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "control" | ||
| }, | ||
| { | ||
| "feature": { | ||
| "featureId": "unused-feature-id-for-legacy-support", | ||
| "enabled": false, | ||
| "value": {} | ||
| }, | ||
| "features": [ | ||
|
Contributor
There was a problem hiding this comment. This second branch doesn't have a |
||
| { | ||
| "enabled": true, | ||
| "featureId": "pocketNewtab", | ||
| "value": { | ||
| "compactLayout": true, | ||
| "lastCardMessageEnabled": true, | ||
| "loadMore": true, | ||
| "newFooterSection": true | ||
| } | ||
| }, | ||
| { | ||
| "featureId": "upgradeDialog", | ||
| "value": { | ||
| "enabled": true | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "treatment" | ||
| } | ||
| ], | ||
| "bucketConfig": { | ||
| "count": 10000, | ||
| "namespace": "firefox-desktop-multifeature-test", | ||
|
There was a problem hiding this comment. The same question as for the Android recipe. Is this form of the namespace the latest and if not, would this affect testing? |
||
| "randomizationUnit": "normandy_id", | ||
| "start": 0, | ||
| "total": 10000 | ||
| }, | ||
| "channel": "nightly", | ||
|
There was a problem hiding this comment. The 95 Firefox version for desktop is currently the Release type.
Contributor
Author
There was a problem hiding this comment. Are you able to pull down previous builds of nightly at the specific version? There was a problem hiding this comment. We ended up using the Release build with the channel changed to Nightly. |
||
| "endDate": null, | ||
| "featureIds": ["upgradeDialog", "pocketNewtab"], | ||
|
Contributor
There was a problem hiding this comment. The
Contributor
There was a problem hiding this comment. Ah, |
||
| "id": "mr2-upgrade-spotlight-holdback", | ||
| "isEnrollmentPaused": false, | ||
| "outcomes": [], | ||
| "probeSets": [], | ||
| "proposedDuration": 63, | ||
| "proposedEnrollment": 7, | ||
| "referenceBranch": "control", | ||
| "schemaVersion": "1.6.2", | ||
| "slug": "firefox-desktop-multifeature-test", | ||
| "startDate": "2021-10-26", | ||
| "targeting": "true", | ||
|
There was a problem hiding this comment. Should targeting be different for desktop? I remember experiments having at least 'app.shield.optoutstudies.enabled'|preferenceValue. I am not sure if this is significant.
Contributor
Author
There was a problem hiding this comment. No it shouldn't be significant here, I tried to set the recipe up so it would definitely enroll. Testing the targeting expressions is handled elsewhere, nothing changes for that here. |
||
| "userFacingDescription": "Experimenting on onboarding content when you upgrade Firefox.", | ||
| "userFacingName": "MR2 Upgrade Spotlight Holdback" | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| { | ||
| "appId": "org.mozilla.ios.Firefox", | ||
| "appName": "firefox_ios", | ||
| "application": "org.mozilla.ios.Firefox", | ||
| "arguments": {}, | ||
| "branches": [ | ||
| { | ||
| "features": [ | ||
| { | ||
| "enabled": true, | ||
| "featureId": "onboarding-default-browser", | ||
| "value": { | ||
| "should-hide-title-image": false | ||
| } | ||
| }, | ||
| { | ||
| "enabled": true, | ||
| "featureId": "homescreen", | ||
| "value": { | ||
| "sections-enabled": { | ||
| "jumpBackIn": false, | ||
| "libraryShortcuts": true, | ||
| "recentlySaved": false | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "control" | ||
| }, | ||
| { | ||
| "features": [ | ||
| { | ||
| "enabled": true, | ||
| "featureId": "onboarding-default-browser", | ||
| "value": { | ||
| "should-hide-title-image": true | ||
| } | ||
| }, | ||
| { | ||
| "enabled": true, | ||
| "featureId": "homescreen", | ||
| "value": { | ||
| "sections-enabled": { | ||
| "jumpBackIn": true, | ||
| "libraryShortcuts": false, | ||
| "recentlySaved": true | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "ratio": 1, | ||
| "slug": "treatment" | ||
| } | ||
| ], | ||
| "bucketConfig": { | ||
| "count": 10000, | ||
| "namespace": "firefox-ios-multifeature-test", | ||
|
There was a problem hiding this comment. The same question as for Android and Desktop, has the namespace format changed? |
||
| "randomizationUnit": "nimbus_id", | ||
| "start": 0, | ||
| "total": 10000 | ||
| }, | ||
| "channel": "release", | ||
| "endDate": null, | ||
| "featureIds": ["onboarding-default-browser", "homescreen"], | ||
| "id": "firefox-ios-multifeature-test", | ||
| "isEnrollmentPaused": false, | ||
| "outcomes": [ | ||
| { | ||
| "priority": "secondary", | ||
| "slug": "default_browser" | ||
| } | ||
| ], | ||
| "probeSets": [], | ||
| "proposedDuration": 28, | ||
| "proposedEnrollment": 7, | ||
| "referenceBranch": "control", | ||
| "schemaVersion": "1.6.2", | ||
| "slug": "firefox-ios-multifeature-test", | ||
| "startDate": "2021-11-01", | ||
| "targeting": "true", | ||
| "userFacingDescription": "firefox-ios-multifeature-test", | ||
| "userFacingName": "firefox-ios-multifeature-test" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember the namespace for multifeature experiments being different, a concatenation of the features used being part of it. Has that changed and if not, will this affect testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that only matters for trying to enroll in multiple multi-feature experiments, I wouldn't worry about it here.