This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Merge feature branch "signing" into master#222
Merged
rehandalal merged 13 commits intomasterfrom Aug 24, 2016
Merged
Conversation
Recipe signing
Autosign recipes, if autograph is available
Contributor
Author
|
@rehandalal Getting these changes merged is blocking progress for the system addon. Once these deploy, we can start having S&I test the addon. Can you look into this soon? |
Contributor
|
r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the signing branch, which consists of PRs #190 and #220, into master so it can be deployed. I think this large feature is ready for integration and deployment.
This gives recipes a cryptographic content signature, and keeps it up to date with a management command. These recipes are automatically added, and not added by any approval process yet.
Since both PRs were reviewed by @Osmose, I'm tagging @rehandalal for this review. Keep in mind this code has already been reviewed, and the question here is whether this feature as a whole is ready for deployment. Though if you find any code review level issues, feel free to bring them up.
NB: Signing relies on a running Autograph server. This can be set up with normandy-compose by building and tagging an image from this PR (
docker build -t somename .), and modifyingdocker-compose.yamlin normandy-compose to use the built image (by tag, ieimage: somename).r?