"All changes saved" action text is wrongly displayed in gray, when Dark Theme is enabled

[Softvision-CristinaBadescu]

[Notes]:

• Considering the discussion from "Synced ..." text is no longer so visible on Dark Theme #645 , it seems that the action text should be displayed in white, for Dark theme.

[Affected versions]:

• Firefox 58.0.1 and up

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with the latest "Firefox Notes" add-on version (2.2.0dev custom build from 2018-02-06) installed.
• Have Dark theme enabled.

[Steps to reproduce]:

1. Open Firefox browser with the profile from prerequisites.
2. Observe the color of the "All changes saved" action text.

[Expected result]:

• The text color is white.

[Actual result]:

• The text color is gray.

[Additional notes]:

• Here is a screen shot with this issue:
  

[Natim]

I know what you mean, in the current form of Notes you can click there to activate the sync but it shouldn't be the case, the action is only on Synced {time} we will fix when we move to react. In the meantime it is fine to have it grey since iti si not supposed to be clickable.

[sebastienbarbier]

I quickly gave a try and fixed it in pull request #550 with light color. This is current result:

Should be merged next week so by then we will be able to do more tests and provide feedbacks.

[sebastienbarbier]

After feedback from natim, non clickable is back to grey, and clickable is white 😊.

[Natim]

@ryanfeeley Does this looks like what you wanted? ^

[vladikoff]

from mtg: ship it says @ryanfeeley