Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Implement Snackbar notification for Notes Deleted #1012

Merged
vladikoff merged 6 commits into
masterfrom
delete-snackbar
May 3, 2018
Merged

Implement Snackbar notification for Notes Deleted #1012
vladikoff merged 6 commits into
masterfrom
delete-snackbar

Conversation

@sebastienbarbier
Copy link
Copy Markdown
Collaborator

@sebastienbarbier sebastienbarbier commented Apr 30, 2018

Fix #926, fix #1018, fix #1020

Comment thread native/app/components/ListPanel.js Outdated
snackbarSyncedvisible: false
});
}}
duration={3000}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this one longer duration, maybe 6 seconds?

@vladikoff
Copy link
Copy Markdown
Contributor

Doesn't work if debug is true ... need to understand why.

In Chrome, dismiss gets called right away, seems like due to a setTimeout getting called right away or something else?

image

With the logcat console the dismiss does not get triggered:

no debugger
05-01 21:11:05.054 30954 32556 I ReactNativeJS: 'componentWillReceiveProps', false
05-01 21:11:07.012 30954 32556 I ReactNativeJS: 'componentWillReceiveProps', true
05-01 21:11:07.461 30954 32556 I ReactNativeJS: 'componentWillReceiveProps', true
05-01 21:11:08.056 30954 32556 I ReactNativeJS: 'componentWillReceiveProps', true
05-01 21:11:10.564 30954 32556 I ReactNativeJS: 'componentWillReceiveProps', true
05-01 21:11:10.564 30954 32556 I ReactNativeJS: _triggerSnackbar

@sebastienbarbier
Copy link
Copy Markdown
Collaborator Author

Implemented the animation 🎉, looks awesome! but undo delete is now broken. Should be easy to fix.

floatingfab
floatingfabdelete

@sebastienbarbier
Copy link
Copy Markdown
Collaborator Author

Aie, bug: Sync snackbar doesn't work anymore after deleting a note, and I can't find why. Will investigate tomorrow, back with WIP label 😓 !

@vladikoff
Copy link
Copy Markdown
Contributor

Ok! Rebase later on

@sebastienbarbier
Copy link
Copy Markdown
Collaborator Author

@vladikoff Can you do some testing, should works fine now 👍

@vladikoff vladikoff merged commit dcd0182 into master May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

2 participants