This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Add a title attribute to the export as HTML menu item. #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
changed the title
Merged
sebastienbarbier
suggested changes
Feb 19, 2018
src/sidebar/app/components/Footer.js
Outdated
| data-mdl-for="context-menu-button"> | ||
| <li> | ||
| <button className="mdl-menu__item context-menu-item" | ||
| <a className="mdl-menu__item context-menu-item" |
There was a problem hiding this comment.
Using trigger some jsx-a11y errors on my machine
Footer.js: line 290, col 17, Error - Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. (jsx-a11y/anchor-is-valid)
Footer.js: line 290, col 17, Error - Visible, non-interactive elements with click handlers must have at least one keyboard listener. (jsx-a11y/click-events-have-key-events)
Footer.js: line 290, col 17, Error - Static HTML elements with event handlers require a role. (jsx-a11y/no-static-element-interactions)
There was a problem hiding this comment.
Yes I just received some travis feedback about that.
@sebastienbarbier review.
sebastienbarbier
approved these changes
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699