Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Fix broken max line limit in react version #706

Merged
merged 4 commits into from
Feb 21, 2018
Merged

Fix broken max line limit in react version #706

merged 4 commits into from
Feb 21, 2018

Conversation

@sebastienbarbier
Copy link
Collaborator

@sebastienbarbier sebastienbarbier commented Feb 20, 2018 •
edited
Loading

Fixes #705

@sebastienbarbier sebastienbarbier self-assigned this Feb 20, 2018
Natim
Natim reviewed Feb 21, 2018
View reviewed changes
src/sidebar/app/components/Editor.js Outdated
this.state = {
ignoreNextLoadEvent: false,
ignoreTextSynced: false,
isLimitReached: false,
Copy link
Collaborator

@Natim Natim Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasLimitReached

@sebastienbarbier sebastienbarbier changed the title WIP: Fix broken max line limit in react version Fix broken max line limit in react version Feb 21, 2018
@sebastienbarbier sebastienbarbier merged commit 51e79e6 into master Feb 21, 2018
@sebastienbarbier sebastienbarbier deleted the 705-max-line-limit-error branch February 21, 2018 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vladikoff vladikoff Awaiting requested review from vladikoff

1 more reviewer

@Natim Natim Natim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sebastienbarbier sebastienbarbier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastienbarbier @Natim @vladikoff