Skip to content

unlisted addons submissions and beta files validation are in beta status (bug 1173064)#578

Merged
magopian merged 1 commit into
mozilla:masterfrom
magopian:1173064-unlisted-addons-beta-files-in-beta
Jun 11, 2015
Merged

unlisted addons submissions and beta files validation are in beta status (bug 1173064)#578
magopian merged 1 commit into
mozilla:masterfrom
magopian:1173064-unlisted-addons-beta-files-in-beta

Conversation

@magopian

Copy link
Copy Markdown
Contributor

Fixes bug 1173064

Listed add-on submission
screen shot 2015-06-10 at 11 54 33

Unlisted add-on submission
screen shot 2015-06-10 at 11 54 19

Upload a new file or add a new version to an unlisted add-on
screen shot 2015-06-10 at 12 01 47

Upload a beta version on a fully reviewed listed add-on, validation failed
screen shot 2015-06-10 at 16 12 21

Upload a beta version on a fully reviewed listed add-on, validation failed, not publishing to beta channel
screen shot 2015-06-10 at 16 12 33

@magopian

Copy link
Copy Markdown
Contributor Author

@kmaglione r? Is that what you had in mind?

@magopian
magopian force-pushed the 1173064-unlisted-addons-beta-files-in-beta branch 2 times, most recently from dea9752 to 397c188 Compare June 10, 2015 15:00
@kmaglione

Copy link
Copy Markdown
Contributor

Yep, this looks perfect. It looks like I forgot one thing when I filed the bug:

We should add "(beta)" to the "Unlisted" checkbox on the devhub add-on versions page, and the same warning to the pop-up confirmation box as to the initial submission dialog.

Sorry I didn't think of that earlier.

@magopian
magopian force-pushed the 1173064-unlisted-addons-beta-files-in-beta branch from 397c188 to 42d122c Compare June 11, 2015 08:39
@magopian

Copy link
Copy Markdown
Contributor Author

No problem, here are the new modifications:

screen shot 2015-06-11 at 23 46 01

Can you please validate the wording on the following one?
screen shot 2015-06-11 at 10 38 59

@kmaglione

Copy link
Copy Markdown
Contributor

The wording looks good. I'm slightly worried that "Unlisted (beta)" suggests that the add-on, rather than the feature, is beta. though. I think "(beta)" should go at the end of the description, but otherwise it looks good.

r+wc

@magopian
magopian force-pushed the 1173064-unlisted-addons-beta-files-in-beta branch from 42d122c to 1e34bd3 Compare June 11, 2015 21:55
magopian added a commit that referenced this pull request Jun 11, 2015
…les-in-beta

unlisted addons submissions and beta files validation are in beta status (bug 1173064)
@magopian
magopian merged commit 8153e76 into mozilla:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants