Skip to content
This repository was archived by the owner on Aug 20, 2018. It is now read-only.

Bug 1097096 - Edit task header blends with task title - #229

Merged
bobsilverberg merged 1 commit into
mozilla:masterfrom
tessie:featureBug1097096
Jan 8, 2015
Merged

Bug 1097096 - Edit task header blends with task title#229
bobsilverberg merged 1 commit into
mozilla:masterfrom
tessie:featureBug1097096

Conversation

@tessie

@tessie tessie commented Dec 22, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@tessie

tessie commented Dec 22, 2014

Copy link
Copy Markdown
Contributor Author

@glogiotatidis @akatsoulas .Please review my PR.Added a colon between update task and taskname in the template

@glogiotatidis

Copy link
Copy Markdown
Contributor

Code is OK. You include 3 commits instead of one, including a commit from another pull request you made. Here's a trick: When you create a new branch, master sure that you switch to the master branch first. So

git checkout master
git branch my_new_shiny_branch
git checkout my_new_shiny_branch

To clean up this pull request the easiest way is to create a new branch and cherry-pick the commit and refers to the current bug.

git checkout master
git branch bug1097096
git checkout bug1097096
git cherry-pick 211ed9554253f5ddb636bacf51613fde7fe0df5b

then git push and make a new pull request. Finally close this one.

Hope that works! Good luck :) 🍀

@tessie

tessie commented Dec 22, 2014

Copy link
Copy Markdown
Contributor Author

@glogiotatidis .Thanks for the review

Bug 1097096 - Edit task header blends with task title

Bug 1097096 - Edit task header blends with task title
@bobsilverberg

Copy link
Copy Markdown
Contributor

Good work, @tessie!

bobsilverberg added a commit that referenced this pull request Jan 8, 2015
 	Bug 1097096 - Edit task header blends with task title
@bobsilverberg
bobsilverberg merged commit 0cde2a1 into mozilla:master Jan 8, 2015
@tessie
tessie deleted the featureBug1097096 branch January 21, 2015 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants