[Bug]: Overlapping link can be clicked through editor toolbar

[LoukasPap]

Attach (recommended) or Link to PDF file

link-overlaps-toolbar.pdf

Web browser and its version

Version 153.0 (64-bit)

Operating system and its version

Windows 11, Version 10.0.26100

PDF.js version

The one bundled with the Firefox version mentioned above

Is the bug present in the latest PDF.js version?

Yes

Is a browser extension

No

Steps to reproduce the problem

1. Set zoom to 100%
2. Highlight "A list of links:" from the 2nd reference
3. Hover over the highlight button in toolbar

What is the expected behavior?

The pointer to be able to click the highlight button

What went wrong?

The pointer can click the link and not the toolbar

Link to a viewer

No response

Additional context

No response

[LoukasPap]

If this is identified as bug, a solution can be to locate the overlapping link element (with class .linkAnnotation) and set pointer-events to none when editToolbar is appearing (or disable all the link elements if this is not a problem). Then, when toolbar is hiding we will enable them again.

[timvandermeij]

Thank you for reporting this! I would say this is a bug indeed: I'd expect the toolbar to be fully on top of the link annotation, and that clicks are targeted towards the toolbar instead of the underlying link annotation.

[Snuffleupagus]

It might be an issue with the z-index of the FloatingToolbar, or something else about its DOM structure that causes this.

[calixteman]

IIRC the toolbar lives in the text layer and since the annotation layer is on top of it...
I think it should be moved somewhere else.

[LoukasPap]

It might be an issue with the z-index of the FloatingToolbar, or something else about its DOM structure that causes this.

Every annotation created has an incrementing (by 2) z-index and text layer has 0 (and must stay like this if I understand correct, so as not to cover the annotation layer entirely).

I see three solutions:

1. Move editToolbar out of text layer, as @calixteman said, but that may require adjusting the position
2. When edit toolbar is opened, disable the pointer events for annotations and re-enable them when it's closed
3. When edit toolbar is opened, set annotation layer to disabled and re-enable it when toolbar is closed (I noticed this is happening with the other edit toolbar when highlightEditing/inkEditing/textEditing)