Add an abstract WasmImage class, that JBig2CCITTFaxImage and JpxImage inherit from#21225
Conversation
…Image` inherit from Given that these classes are, with the exception of their `decode` methods, virtually identical this helps reduce code duplication and simplifies maintenance. These changes reduce the size of the `gulp mozcentral` build-target by `1292` bytes, which obviously isn't a lot but still cannot hurt.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21225 +/- ##
==========================================
- Coverage 55.94% 55.93% -0.02%
==========================================
Files 219 220 +1
Lines 59017 58988 -29
==========================================
- Hits 33020 32992 -28
+ Misses 25997 25996 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0446ed0fb1f2412/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/120a137b60844aa/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0446ed0fb1f2412/output.txt Total script time: 18.10 mins
Image differences available at: http://54.241.84.105:8877/0446ed0fb1f2412/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/120a137b60844aa/output.txt Total script time: 24.44 mins
Image differences available at: http://54.193.163.58:8877/120a137b60844aa/reftest-analyzer.html#web=eq.log |
Given that these classes are, with the exception of their
decodemethods, virtually identical this helps reduce code duplication and simplifies maintenance.These changes reduce the size of the
gulp mozcentralbuild-target by1292bytes, which obviously isn't a lot but still cannot hurt.Note: This implements the suggestion from #21139 (comment).