Tweak the WasmImage implementation a little bit (PR 21225 follow-up)#21229
Merged
Conversation
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21229 +/- ##
==========================================
- Coverage 55.93% 55.92% -0.01%
==========================================
Files 220 220
Lines 58990 58991 +1
==========================================
- Hits 32994 32989 -5
- Misses 25996 26002 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This fixes two things that I overlooked in PR 21225, more specifically: - Use proper, rather than semi, private class fields in `WasmImage`. - Make tracking of `WasmImage` instances optional, to avoid keeping data alive permanently in the `IMAGE_DECODERS` build.
Snuffleupagus
force-pushed
the
WasmImage-private
branch
from
4efb97e to
3f6a2fe
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Collaborator
Author
|
Update the patch to revert the filename-related changes, to not make these classes more annoying to use standalone. /botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6356d4f8be56776/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fab7febf5bc05e2/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6356d4f8be56776/output.txt Total script time: 18.46 mins
Image differences available at: http://54.241.84.105:8877/6356d4f8be56776/reftest-analyzer.html#web=eq.log |
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fab7febf5bc05e2/output.txt Total script time: 24.72 mins
Image differences available at: http://54.193.163.58:8877/fab7febf5bc05e2/reftest-analyzer.html#web=eq.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two things that I overlooked in PR #21225, more specifically:
Use proper, rather than semi, private class fields in
WasmImage.Make tracking of
WasmImageinstances optional, to avoid keeping data alive permanently in theIMAGE_DECODERSbuild.