[Editor] Restore pinch-to-resize on an editor which came back from an undo - #21644
Merged
calixteman merged 1 commit intoJul 29, 2026
Merged
Conversation
calixteman
had a problem deploying
to
code-coverage
July 27, 2026 15:15 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21644 +/- ##
==========================================
+ Coverage 89.79% 89.96% +0.16%
==========================================
Files 263 263
Lines 66884 66887 +3
==========================================
+ Hits 60061 60173 +112
+ Misses 6823 6714 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Jul 28, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with the comment about the toBeGreaterThan line addressed. Thank youu for fixing this!
calixteman
force-pushed
the
editor/pinch-lost-after-undo
branch
from
July 29, 2026 12:44
ef1b3e5 to
cd63fe4
Compare
calixteman
had a problem deploying
to
code-coverage
July 29, 2026 12:44 — with
GitHub Actions
Failure
GitHub Actions
Failure
… undo `AnnotationEditor.remove()` destroys the editor's `TouchManager`, but `remove()` is also the undo half of an edit: deleting a drawing and undoing it, or undoing the drawing itself and redoing it, brings the very same editor back.
calixteman
force-pushed
the
editor/pinch-lost-after-undo
branch
from
July 29, 2026 12:45
cd63fe4 to
822d3ea
Compare
calixteman
had a problem deploying
to
code-coverage
July 29, 2026 12:45 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnnotationEditor.remove()destroys the editor'sTouchManager, butremove()is also the undo half of an edit: deleting a drawing and undoing it, or undoing the drawing itself and redoing it, brings the very same editor back.