Re-factor the EventBus to use Map/Set internally - #21673
Merged
Merged
Conversation
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:00 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21673 +/- ##
=======================================
Coverage 89.97% 89.98%
=======================================
Files 263 263
Lines 66901 66896 -5
=======================================
Hits 60196 60196
+ Misses 6705 6700 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Especially the Array to Set conversion should be helpful, since adding/removing elements from a Set is more efficient.
Snuffleupagus
force-pushed
the
EventBus-Map-Set
branch
from
July 31, 2026 15:37
c04c5d8 to
0d5df9d
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 31, 2026 15:37 — with
GitHub Actions
Inactive
timvandermeij
approved these changes
Jul 31, 2026
Collaborator
|
Thank you for simplifying this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially the Array to Set conversion should be helpful, since adding/removing elements from a Set is more efficient.