Skip to content

Re-factor the EventBus to use Map/Set internally - #21673

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:EventBus-Map-Set
Jul 31, 2026
Merged

Re-factor the EventBus to use Map/Set internally#21673
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:EventBus-Map-Set

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Especially the Array to Set conversion should be helpful, since adding/removing elements from a Set is more efficient.

@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (ce4ff55) to head (0d5df9d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21673   +/-   ##
=======================================
  Coverage   89.97%   89.98%           
=======================================
  Files         263      263           
  Lines       66901    66896    -5     
=======================================
  Hits        60196    60196           
+ Misses       6705     6700    -5     
Flag Coverage Δ
browsertest 66.53% <0.00%> (-0.02%) ⬇️
integrationtest 69.32% <100.00%> (-0.01%) ⬇️
unittest 57.82% <100.00%> (-0.01%) ⬇️
unittestcli 56.54% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Especially the Array to Set conversion should be helpful, since adding/removing elements from a Set is more efficient.
@timvandermeij
timvandermeij merged commit 4b4c784 into mozilla:master Jul 31, 2026
17 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for simplifying this!

@Snuffleupagus
Snuffleupagus deleted the EventBus-Map-Set branch August 1, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants