Skip to content

Let pointerup/cancel propagate in TouchManager - #21674

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:touch/fix-swallowed-pointerup
Jul 31, 2026
Merged

Let pointerup/cancel propagate in TouchManager#21674
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:touch/fix-swallowed-pointerup

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

During two-finger gestures, keep preventing the default action on pointerup/pointercancel, but don't stop propagation. Resize/drag sessions need those bubble events to clean up.

During two-finger gestures, keep preventing the default action on pointerup/pointercancel, but don't stop propagation. Resize/drag sessions need those bubble events to clean up.
@calixteman
calixteman requested a review from timvandermeij July 31, 2026 17:28
@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (af38789) to head (0f999e2).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21674      +/-   ##
==========================================
- Coverage   89.99%   89.98%   -0.01%     
==========================================
  Files         263      263              
  Lines       66900    66901       +1     
==========================================
- Hits        60204    60199       -5     
- Misses       6696     6702       +6     
Flag Coverage Δ
browsertest 66.52% <0.00%> (-0.01%) ⬇️
fonttest 9.04% <ø> (ø)
integrationtest 69.34% <100.00%> (-0.01%) ⬇️
unittest 57.83% <0.00%> (-0.01%) ⬇️
unittestcli 56.56% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 7fc7072 into mozilla:master Jul 31, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thank you for fixing this and for making sure we have a good way to test pinch actions now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants