Skip to content

Fix the regex used to normalize css fonts in XFA - #21680

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex
Aug 2, 2026
Merged

Fix the regex used to normalize css fonts in XFA#21680
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

The regex was quadratic in the number of consecutive spaces, which caused performance issues when normalizing fonts with a large number of spaces.

The regex was quadratic in the number of consecutive spaces,
which caused performance issues when normalizing fonts with
a large number of spaces.
@codecov-commenter

codecov-commenter commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (7fc7072) to head (491792f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21680   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         263      263           
  Lines       66854    66855    +1     
=======================================
+ Hits        60173    60175    +2     
+ Misses       6681     6680    -1     
Flag Coverage Δ
browsertest 66.54% <100.00%> (+<0.01%) ⬆️
fonttest 9.04% <0.00%> (-0.01%) ⬇️
integrationtest 69.36% <100.00%> (+<0.01%) ⬆️
unittest 57.83% <66.66%> (-0.02%) ⬇️
unittestcli 56.57% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser tests. Thank you for improving this!

@timvandermeij

Copy link
Copy Markdown
Collaborator

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8818e0c2a19f1e8/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5b13901d9a08a7c/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8818e0c2a19f1e8/output.txt

Total script time: 16.50 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/5b13901d9a08a7c/output.txt

Total script time: 23.42 mins

  • Regression tests: Passed

@timvandermeij
timvandermeij merged commit f739780 into mozilla:master Aug 2, 2026
21 checks passed
@calixteman
calixteman deleted the fix/quad-regex branch August 2, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants