Fix the regex used to normalize css fonts in XFA - #21680
Conversation
The regex was quadratic in the number of consecutive spaces, which caused performance issues when normalizing fonts with a large number of spaces.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21680 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 263 263
Lines 66854 66855 +1
=======================================
+ Hits 60173 60175 +2
+ Misses 6681 6680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests. Thank you for improving this!
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8818e0c2a19f1e8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5b13901d9a08a7c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8818e0c2a19f1e8/output.txt Total script time: 16.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5b13901d9a08a7c/output.txt Total script time: 23.42 mins
|
The regex was quadratic in the number of consecutive spaces, which caused performance issues when normalizing fonts with a large number of spaces.