Don't throw on an invalid XML character reference - #21682
Merged
Conversation
`String.fromCodePoint` throws on anything which isn't a code point, so e.g. "&#xZZ;" or "�" aborted the whole parsing. Such a reference is now kept as-is, like an unknown named entity.
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
had a problem deploying
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Failure
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 1, 2026 16:13 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21682 +/- ##
==========================================
- Coverage 90.00% 90.00% -0.01%
==========================================
Files 263 263
Lines 66854 66853 -1
==========================================
- Hits 60173 60171 -2
- Misses 6681 6682 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Aug 2, 2026
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.fromCodePointthrows on anything which isn't a code point, so e.g. "&#xZZ;" or "�" aborted the whole parsing. Such a reference is now kept as-is, like an unknown named entity.