Skip to content

Don't throw on an invalid XML character reference - #21682

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/xml-invalid-char-ref
Aug 2, 2026
Merged

Don't throw on an invalid XML character reference#21682
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/xml-invalid-char-ref

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

String.fromCodePoint throws on anything which isn't a code point, so e.g. "&#xZZ;" or "�" aborted the whole parsing. Such a reference is now kept as-is, like an unknown named entity.

`String.fromCodePoint` throws on anything which isn't a code point,
so e.g. "&#xZZ;" or "�" aborted the whole parsing. Such a
reference is now kept as-is, like an unknown named entity.
@calixteman calixteman added the core label Aug 1, 2026
@codecov-commenter

codecov-commenter commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (7fc7072) to head (cec8d2e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21682      +/-   ##
==========================================
- Coverage   90.00%   90.00%   -0.01%     
==========================================
  Files         263      263              
  Lines       66854    66853       -1     
==========================================
- Hits        60173    60171       -2     
- Misses       6681     6682       +1     
Flag Coverage Δ
browsertest 66.53% <100.00%> (-0.01%) ⬇️
fonttest 9.04% <ø> (ø)
integrationtest 69.36% <100.00%> (+<0.01%) ⬆️
unittest 57.83% <100.00%> (-0.01%) ⬇️
unittestcli 56.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 5dc1d0c into mozilla:master Aug 2, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants