Skip to content

Trim the response headers with a backward scan - #21684

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-headers
Aug 2, 2026
Merged

Trim the response headers with a backward scan#21684
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-headers

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Removing the trailing whitespace with a $-anchored regex is quadratic in the length of the run, which a server controls. The helper lives in network_utils.js, to be unit testable.

Removing the trailing whitespace with a `$`-anchored regex is
quadratic in the length of the run, which a server controls.
The helper lives in network_utils.js, to be unit testable.
@codecov-commenter

codecov-commenter commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (7fc7072) to head (cba911d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21684   +/-   ##
=======================================
  Coverage   90.00%   90.01%           
=======================================
  Files         263      263           
  Lines       66854    66858    +4     
=======================================
+ Hits        60173    60180    +7     
+ Misses       6681     6678    -3     
Flag Coverage Δ
browsertest 66.55% <0.00%> (+0.01%) ⬆️
fonttest 9.04% <ø> (ø)
integrationtest 69.36% <100.00%> (+<0.01%) ⬆️
unittest 57.83% <100.00%> (-0.01%) ⬇️
unittestcli 56.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit eb8f6af into mozilla:master Aug 2, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants