Skip to content

Anchor the regex used to extract the XFA path positions - #21686

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-xfa-path
Aug 3, 2026
Merged

Anchor the regex used to extract the XFA path positions#21686
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-xfa-path

Conversation

@calixteman

@calixteman calixteman commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Matching the name with a leading .+ is quadratic in the length of a component which doesn't end with a position, and every AcroForm field name goes through this.

@calixteman calixteman added the core label Aug 1, 2026
@codecov-commenter

codecov-commenter commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (d0779c4) to head (92d027e).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21686      +/-   ##
==========================================
- Coverage   90.00%   90.00%   -0.01%     
==========================================
  Files         263      263              
  Lines       66861    66861              
==========================================
- Hits        60178    60177       -1     
- Misses       6683     6684       +1
Flag Coverage Δ
browsertest 66.52% <100.00%> (-0.01%) ⬇️
fonttest 9.04% <0.00%> (ø)
integrationtest 69.34% <0.00%> (-0.02%) ⬇️
unittest 57.86% <100.00%> (+0.03%) ⬆️
unittestcli 56.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

timvandermeij
timvandermeij approved these changes Aug 2, 2026
View reviewed changes

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed. Thanks!

Comment thread src/core/core_utils.js
@calixteman
Anchor the regex used to extract the XFA path positions
92d027e 
Matching the name with a leading `.+` is quadratic in the length of
a component which doesn't end with a position, and every AcroForm
field name goes through this.
@calixteman
calixteman force-pushed the fix/quad-regex-xfa-path branch from a32f266 to 92d027e Compare August 3, 2026 15:08
@calixteman calixteman changed the title Extract the XFA path positions without a regex Anchor the regex used to extract the XFA path positions Aug 3, 2026
@calixteman
calixteman merged commit 1da36fb into mozilla:master Aug 3, 2026
21 checks passed
@calixteman
calixteman deleted the fix/quad-regex-xfa-path branch August 3, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @codecov-commenter @timvandermeij