Exclude "&" from the XML entity names - #21692
Merged
timvandermeij merged 1 commit intoAug 2, 2026
Merged
Conversation
Scanning to the end of the string for every "&" made the entity resolution quadratic. Stopping at the next "&" also fixes a bare ampersand swallowing the reference which follows it.
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
had a problem deploying
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Failure
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 2, 2026 17:00 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21692 +/- ##
==========================================
- Coverage 90.00% 89.99% -0.01%
==========================================
Files 263 263
Lines 66861 66861
==========================================
- Hits 60178 60172 -6
- Misses 6683 6689 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Aug 2, 2026
Collaborator
|
Thank you for improving this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scanning to the end of the string for every "&" made the entity resolution quadratic. Stopping at the next "&" also fixes a bare ampersand swallowing the reference which follows it.