Skip to content

Exclude "&" from the XML entity names - #21692

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-xml-entities
Aug 2, 2026
Merged

Exclude "&" from the XML entity names#21692
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/quad-regex-xml-entities

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Scanning to the end of the string for every "&" made the entity resolution quadratic. Stopping at the next "&" also fixes a bare ampersand swallowing the reference which follows it.

Scanning to the end of the string for every "&" made the entity
resolution quadratic. Stopping at the next "&" also fixes a bare
ampersand swallowing the reference which follows it.
@calixteman calixteman added the core label Aug 2, 2026
@codecov-commenter

codecov-commenter commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.99%. Comparing base (d0779c4) to head (f7f30dd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21692      +/-   ##
==========================================
- Coverage   90.00%   89.99%   -0.01%     
==========================================
  Files         263      263              
  Lines       66861    66861              
==========================================
- Hits        60178    60172       -6     
- Misses       6683     6689       +6     
Flag Coverage Δ
browsertest 66.53% <100.00%> (+<0.01%) ⬆️
fonttest 9.04% <ø> (ø)
integrationtest 69.33% <100.00%> (-0.03%) ⬇️
unittest 57.86% <100.00%> (+0.03%) ⬆️
unittestcli 56.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit ec69113 into mozilla:master Aug 2, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants