Skip to content

Avoid an infinite loop on cyclic field Parent chains - #21699

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/pdf-editor-field-parent-cycle
Aug 4, 2026
Merged

Avoid an infinite loop on cyclic field Parent chains#21699
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/pdf-editor-field-parent-cycle

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

When an AcroForm has no Fields entry, #fixFields rebuilds it by walking each widget's Parent chain up to its root field. A chain looping back on itself made that walk spin forever and hung the worker.

When an AcroForm has no Fields entry, #fixFields rebuilds it by walking
each widget's Parent chain up to its root field. A chain looping back on
itself made that walk spin forever and hung the worker.
@codecov-commenter

codecov-commenter commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (b4ba666) to head (a7a99fd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21699   +/-   ##
=======================================
  Coverage   90.01%   90.02%           
=======================================
  Files         264      264           
  Lines       66893    66904   +11     
=======================================
+ Hits        60214    60227   +13     
+ Misses       6679     6677    -2     
Flag Coverage Δ
browsertest 66.52% <0.00%> (-0.02%) ⬇️
fonttest 9.03% <ø> (ø)
integrationtest 69.33% <0.00%> (-0.01%) ⬇️
unittest 57.88% <100.00%> (+<0.01%) ⬆️
unittestcli 56.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 8e3a1fd into mozilla:master Aug 4, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Nice find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants