Remove the ambiguity from the PostScript number regex - #21709
Merged
Conversation
`\d+\.?\d*` can split a run of digits in as many ways as it is long, so it would backtrack polynomially if anything following it could reject. The optional exponent can't, hence no bug today, but `\d+(?:\.\d*)?` accepts the same numbers unambiguously.
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
had a problem deploying
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Failure
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 16:56 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21709 +/- ##
==========================================
- Coverage 90.04% 90.02% -0.02%
==========================================
Files 264 264
Lines 66894 66894
==========================================
- Hits 60232 60220 -12
- Misses 6662 6674 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Aug 4, 2026
Collaborator
|
Preventing issues here seems like a good idea, so thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\d+\.?\d*can split a run of digits in as many ways as it is long, so it would backtrack polynomially if anything following it could reject. The optional exponent can't, hence no bug today, but\d+(?:\.\d*)?accepts the same numbers unambiguously.