Convert TranslatedFont.prototype.loadType3Data to an asynchronous method - #21719
Conversation
…ethod The Type3 glyphs are parsed in series, which was implemented by chaining the `getOperatorList` promises together one after another. Thanks to modern JavaScript this can be simplified a little bit, since we can just `await` within the loop instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21719 +/- ##
==========================================
+ Coverage 90.03% 90.05% +0.01%
==========================================
Files 264 264
Lines 66939 66936 -3
==========================================
+ Hits 60267 60277 +10
+ Misses 6672 6659 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc8a32dd943d392/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7c809e3caa4db3d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cc8a32dd943d392/output.txt Total script time: 16.65 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7c809e3caa4db3d/output.txt Total script time: 23.41 mins
|
|
Thank you for simplifying this a bit! |
The Type3 glyphs are parsed in series, which was implemented by chaining the
getOperatorListpromises together one after another.Thanks to modern JavaScript this can be simplified a little bit, since we can just
awaitwithin the loop instead.Smaller diff with https://github.com/mozilla/pdf.js/pull/21719/changes?w=1