Skip to content

Move SCALE_MATRIX into CanvasGraphics and initialize its DOMMatrix lazily (issue 21720) - #21721

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:canvas-SCALE_MATRIX-lazy
Aug 6, 2026
Merged

Move SCALE_MATRIX into CanvasGraphics and initialize its DOMMatrix lazily (issue 21720)#21721
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:canvas-SCALE_MATRIX-lazy

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

While this shouldn't affect performance negatively, it does however (ever so slightly) increase the bundle size of the Firefox PDF Viewer.
If that's not desirable, since it's only needed in order to improve Node.js compatibility, we could also just WONTFIX the issue.

…ix` lazily (issue 21720)

While this shouldn't affect performance negatively, it does however (ever so slightly) increase the bundle size of the Firefox PDF Viewer.
If that's not desirable, since it's only needed in order to improve Node.js compatibility, we could also just WONTFIX the issue.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@codecov-commenter

codecov-commenter commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (1b4055e) to head (ac5aa27).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21721      +/-   ##
==========================================
+ Coverage   90.02%   90.05%   +0.02%     
==========================================
  Files         264      264              
  Lines       66937    66938       +1     
==========================================
+ Hits        60262    60278      +16     
+ Misses       6675     6660      -15     
Flag Coverage Δ
browsertest 66.48% <100.00%> (+<0.01%) ⬆️
fonttest 9.03% <ø> (ø)
integrationtest 69.36% <100.00%> (+0.02%) ⬆️
unittest 57.96% <50.00%> (-0.01%) ⬇️
unittestcli 56.72% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e8f8c81b0e15623/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/29fa3e4d9962487/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/e8f8c81b0e15623/output.txt

Total script time: 16.56 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/29fa3e4d9962487/output.txt

Total script time: 23.35 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus merged commit 71a3c6a into mozilla:master Aug 6, 2026
20 of 21 checks passed
@Snuffleupagus
Snuffleupagus deleted the canvas-SCALE_MATRIX-lazy branch August 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants