Skip to content

Track container touches in TouchManager - #21722

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:touch/fix-foreign-fingers
Aug 7, 2026
Merged

Track container touches in TouchManager#21722
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:touch/fix-foreign-fingers

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Touch events are dispatched for the changed touches' targets, but evt.touches is global.

Track the identifiers that started on this manager's container and derive pinch state from that set. Unrelated fingers then neither keep editor pinch-resize alive nor become part of its pair.

@codecov-commenter

codecov-commenter commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (f43ce86) to head (d73dc99).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/display/touch_manager.js 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21722      +/-   ##
==========================================
+ Coverage   90.04%   90.05%   +0.01%     
==========================================
  Files         264      264              
  Lines       66935    66960      +25     
==========================================
+ Hits        60270    60303      +33     
+ Misses       6665     6657       -8     
Flag Coverage Δ
browsertest 66.44% <0.00%> (-0.03%) ⬇️
fonttest 9.03% <ø> (+<0.01%) ⬆️
integrationtest 69.38% <84.84%> (+0.01%) ⬆️
unittest 58.13% <96.96%> (+0.16%) ⬆️
unittestcli 56.69% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij

Copy link
Copy Markdown
Collaborator

r=me, with passing CI. Thanks!

Touch events are dispatched for the changed touches' targets, but evt.touches is global.

Track the identifiers that started on this manager's container and derive pinch state from that set. Unrelated fingers then neither keep editor pinch-resize alive nor become part of its pair.
@calixteman
calixteman merged commit ff784c7 into mozilla:master Aug 7, 2026
21 checks passed
@calixteman
calixteman deleted the touch/fix-foreign-fingers branch August 7, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants