Improve glyph mapping for non-embedded CID fonts - #21726
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21726 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.01%
==========================================
Files 264 264
Lines 66938 67034 +96
==========================================
+ Hits 60281 60379 +98
+ Misses 6657 6655 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a3b99ac3ef12bc7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aa4d66069aeb197/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a3b99ac3ef12bc7/output.txt Total script time: 16.64 mins
Image differences available at: http://54.241.84.105:8877/a3b99ac3ef12bc7/reftest-analyzer.html#web=eq.log |
When a non-embedded CID font lacks both a glyph map and a ToUnicode entry, its CIDs are glyph IDs and PDF.js must infer an ordering. The standard-font map does not match Trebuchet MS or Windows Symbol. Build the Trebuchet MS mapping from MacStandardGlyphOrdering plus supplemental entries, and map Windows Symbol glyph IDs by character code. Also map Adobe arrow and integral extenders from private-use code points to Unicode. It fixes mozilla#21713.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/aa4d66069aeb197/output.txt Total script time: 23.75 mins
Image differences available at: http://54.193.163.58:8877/aa4d66069aeb197/reftest-analyzer.html#web=eq.log |
|
Looks good, including the reference test differences. Thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d4dabd472ca85e3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3c9876a5fcf3dd4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d4dabd472ca85e3/output.txt Total script time: 16.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3c9876a5fcf3dd4/output.txt Total script time: 23.74 mins
|
When a non-embedded CID font lacks both a glyph map and a ToUnicode entry, its CIDs are glyph IDs and PDF.js must infer an ordering. The standard-font map does not match Trebuchet MS or Windows Symbol.
Build the Trebuchet MS mapping from MacStandardGlyphOrdering plus supplemental entries, and map Windows Symbol glyph IDs by character code. Also map Adobe arrow and integral extenders from private-use code points to Unicode.
It fixes #21713.