Skip to content

Convert the charProcOperatorList, used with Type3 fonts, to a Map - #21730

Merged
Snuffleupagus merged 2 commits into
mozilla:masterfrom
Snuffleupagus:charProcOperatorList-Map
Aug 7, 2026
Merged

Convert the charProcOperatorList, used with Type3 fonts, to a Map#21730
Snuffleupagus merged 2 commits into
mozilla:masterfrom
Snuffleupagus:charProcOperatorList-Map

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator
  • Remove unnecessary RefSet.prototype.has call from TranslatedFont.prototype.loadType3Data

    The RefSet class stores its data in a Set and in those a value can only occur exactly once, hence we can simply invoke RefSet.prototype.put unconditionally.

  • Convert the charProcOperatorList, used with Type3 fonts, to a Map

…rototype.loadType3Data`

The `RefSet` class stores its data in a Set and in those a value can only occur exactly once, hence we can simply invoke `RefSet.prototype.put` unconditionally.
@codecov-commenter

codecov-commenter commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (0ccb35c) to head (1365dbd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21730      +/-   ##
==========================================
- Coverage   90.06%   90.06%   -0.01%     
==========================================
  Files         264      264              
  Lines       67094    67094              
==========================================
- Hits        60429    60428       -1     
- Misses       6665     6666       +1     
Flag Coverage Δ
browsertest 66.29% <100.00%> (-0.03%) ⬇️
fonttest 9.03% <ø> (ø)
integrationtest 69.36% <0.00%> (+0.01%) ⬆️
unittest 58.34% <80.00%> (-0.01%) ⬇️
unittestcli 56.71% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/89f0ebdb91b4789/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/00602ba8befb748/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/00602ba8befb748/output.txt

Total script time: 16.52 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/89f0ebdb91b4789/output.txt

Total script time: 23.33 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus merged commit 022e958 into mozilla:master Aug 7, 2026
23 of 25 checks passed
@Snuffleupagus
Snuffleupagus deleted the charProcOperatorList-Map branch August 7, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants