Re-name the RefSetCache class to RefMap - #21737
Merged
Merged
Conversation
The `RefSet` and `RefSetCache` classes are old enough that they predate a lot of modern JavaScript features, e.g. originally they stored their data in regular Objects. About six years ago, see PRs 11977 and 12089, these classes were converted to use a Set respectively a Map internally. Given that `RefSet` is a wrapper around a standard Set, it seems reasonable to re-name `RefSetCache` to `RefMap` when it's a wrapper around a standard Map.
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 09:59 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21737 +/- ##
==========================================
+ Coverage 90.05% 90.08% +0.03%
==========================================
Files 264 264
Lines 67094 67093 -1
==========================================
+ Hits 60422 60442 +20
+ Misses 6672 6651 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Aug 9, 2026
Collaborator
|
Good idea; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RefSetandRefSetCacheclasses are old enough that they predate a lot of modern JavaScript features, e.g. originally they stored their data in regular Objects.About six years ago, see PRs #11977 and #12089, these classes were converted to use a Set respectively a Map internally.
Given that
RefSetis a wrapper around a standard Set, it seems reasonable to re-nameRefSetCachetoRefMapwhen it's a wrapper around a standard Map.