Replace most toBeTruthy()/toBeFalsy() matchers with more specific ones in the unit-tests - #21739
Merged
Snuffleupagus merged 1 commit intoAug 9, 2026
Conversation
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:51 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21739 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 264 264
Lines 67190 67190
=======================================
+ Hits 60519 60521 +2
+ Misses 6671 6669 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Snuffleupagus
force-pushed
the
test-replace-most-toBeTruthy-toBeFalsy
branch
from
August 8, 2026 20:57
84919e9 to
d9166ae
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 8, 2026 20:57 — with
GitHub Actions
Inactive
timvandermeij
approved these changes
Aug 9, 2026
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with the merge conflict fixed. This seems better indeed.
… ones in the unit-tests Generally speaking it seems like a good idea to have the unit-tests be *explicit* about their expected values, rather than accepting "arbitrary" truthy/falsy values.
Snuffleupagus
force-pushed
the
test-replace-most-toBeTruthy-toBeFalsy
branch
from
August 9, 2026 18:04
d9166ae to
963bd50
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 9, 2026 18:04 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally speaking it seems like a good idea to have the unit-tests be explicit about their expected values, rather than accepting "arbitrary" truthy/falsy values.