Skip to content

Re-use the stringToBytes helper in the encodeASCIIString function - #21743

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:encodeASCIIString-use-stringToBytes
Aug 10, 2026
Merged

Re-use the stringToBytes helper in the encodeASCIIString function#21743
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:encodeASCIIString-use-stringToBytes

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (c2bbde1) to head (b82de31).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21743      +/-   ##
==========================================
- Coverage   90.09%   90.09%   -0.01%     
==========================================
  Files         264      264              
  Lines       67194    67234      +40     
==========================================
+ Hits        60538    60572      +34     
- Misses       6656     6662       +6     
Flag Coverage Δ
browsertest 66.35% <100.00%> (-0.04%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.29% <100.00%> (+<0.01%) ⬆️
unittest 58.23% <100.00%> (-0.04%) ⬇️
unittestcli 56.60% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 959f1c4 into mozilla:master Aug 10, 2026
21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you!

@Snuffleupagus
Snuffleupagus deleted the encodeASCIIString-use-stringToBytes branch August 10, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants