Skip to content

[Editor] End active touch gestures on destroy - #21744

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:touch/end-gesture-on-destroy
Aug 10, 2026
Merged

[Editor] End active touch gestures on destroy#21744
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:touch/end-gesture-on-destroy

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Destroy an editor's touch manager before detaching it so onPinchEnd can restore pointer events and record any resize.

Destroy an editor's touch manager before detaching it so `onPinchEnd` can restore pointer events and record any resize.
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (7364bca) to head (8f487ef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21744      +/-   ##
==========================================
- Coverage   90.09%   90.09%   -0.01%     
==========================================
  Files         264      264              
  Lines       67234    67237       +3     
==========================================
+ Hits        60574    60576       +2     
- Misses       6660     6661       +1     
Flag Coverage Δ
browsertest 66.34% <0.00%> (-0.01%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.30% <100.00%> (-0.01%) ⬇️
unittest 58.23% <81.81%> (+0.01%) ⬆️
unittestcli 56.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 1072984 into mozilla:master Aug 10, 2026
20 of 21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants