Add more unit-tests for the src/core/primitives.js file - #21820
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21820 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 264 264
Lines 67322 67321 -1
=======================================
Hits 60729 60729
+ Misses 6593 6592 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add unit-tests for various "error branches" in the code, which brings code coverage of this file to *almost* 100 percent. Also, add a couple of unit-tests for the `Ref.fromString` functionality since it was only indirectly tested.
1bef6a4 to
8dd03be
Compare
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c03ae22db781d28/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a17a901e99d7b86/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a17a901e99d7b86/output.txt Total script time: 18.11 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c03ae22db781d28/output.txt Total script time: 23.50 mins
|
timvandermeij
left a comment
There was a problem hiding this comment.
More tests can never hurt; thank you!
Add unit-tests for various "error branches" in the code, which brings code coverage of this file to almost 100 percent.
Also, add a couple of unit-tests for the
Ref.fromStringfunctionality since it was only indirectly tested.