Skip to content

[api-minor] Convert documentInfo to return any "Custom" data in a Map - #21828

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:documentInfo-Custom-Map
Aug 27, 2026
Merged

[api-minor] Convert documentInfo to return any "Custom" data in a Map#21828
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:documentInfo-Custom-Map

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

The "Custom" entry is a feature that, outside of a single unit-test, isn't used anywhere in the PDF.js code-base.
Besides changing this data to use a Map, rather than a regular Object, the validation can be moved since it's not necessary when a white-listed type has been encountered.

The "Custom" entry is a feature that, outside of a single unit-test, isn't used anywhere in the PDF.js code-base.
Besides changing this data to use a Map, rather than a regular Object, the validation can be moved since it's not necessary when a white-listed type has been encountered.
@Snuffleupagus Snuffleupagus added core release-blocker Blocker for the upcoming release labels Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (49ff3dc) to head (3707b66).

Files with missing lines Patch % Lines
src/core/document.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21828      +/-   ##
==========================================
+ Coverage   90.18%   90.20%   +0.01%     
==========================================
  Files         264      264              
  Lines       67312    67310       -2     
==========================================
+ Hits        60707    60715       +8     
+ Misses       6605     6595      -10     
Flag Coverage Δ
browsertest 66.30% <0.00%> (-0.03%) ⬇️
fonttest 8.92% <ø> (ø)
integrationtest 69.42% <25.00%> (+0.01%) ⬆️
unittest 58.37% <25.00%> (-0.01%) ⬇️
unittestcli 56.94% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 2974ee9 into mozilla:master Aug 27, 2026
21 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you!

@Snuffleupagus
Snuffleupagus deleted the documentInfo-Custom-Map branch August 28, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core release-blocker Blocker for the upcoming release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants