Skip to content

Tweak the WorkerTask class and the hasJSActions getter - #21841

Merged
timvandermeij merged 2 commits into
mozilla:masterfrom
Snuffleupagus:src-core-misc-fixes
Aug 29, 2026
Merged

Tweak the WorkerTask class and the hasJSActions getter#21841
timvandermeij merged 2 commits into
mozilla:masterfrom
Snuffleupagus:src-core-misc-fixes

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator
  • Move some WorkerTask class field definitions out of the constructor

    Also, make use of actually private fields in one case.

  • Inline the PDFDocument.prototype._parseHasJSActions method

    This code is short and simple enough that it can just be inlined in the hasJSActions getter.


Smaller diff with https://github.com/mozilla/pdf.js/pull/21841/changes?w=1

Also, make use of actually private fields in one case.
This code is short and simple enough that it can just be inlined in the `hasJSActions` getter.
@codecov-commenter

codecov-commenter commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (d1725ab) to head (67c035f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21841      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         264      264              
  Lines       67286    67285       -1     
==========================================
- Hits        60723    60718       -5     
- Misses       6563     6567       +4     
Flag Coverage Δ
browsertest 66.32% <25.00%> (+<0.01%) ⬆️
fonttest 8.92% <ø> (ø)
integrationtest 69.43% <91.66%> (-0.02%) ⬇️
unittest 58.44% <100.00%> (-0.01%) ⬇️
unittestcli 56.99% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/21e7be26f3c1643/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/81146a0f11c2a6c/output.txt

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thanks!

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/81146a0f11c2a6c/output.txt

Total script time: 19.02 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/21e7be26f3c1643/output.txt

Total script time: 23.78 mins

  • Regression tests: Passed

@timvandermeij
timvandermeij merged commit 1c8020a into mozilla:master Aug 29, 2026
21 checks passed
@Snuffleupagus
Snuffleupagus deleted the src-core-misc-fixes branch August 29, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants