Tweak the WorkerTask class and the hasJSActions getter - #21841
Conversation
Also, make use of actually private fields in one case.
This code is short and simple enough that it can just be inlined in the `hasJSActions` getter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21841 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 264 264
Lines 67286 67285 -1
==========================================
- Hits 60723 60718 -5
- Misses 6563 6567 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/21e7be26f3c1643/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/81146a0f11c2a6c/output.txt |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing tests. Thanks!
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/81146a0f11c2a6c/output.txt Total script time: 19.02 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/21e7be26f3c1643/output.txt Total script time: 23.78 mins
|
Move some
WorkerTaskclass field definitions out of the constructorAlso, make use of actually private fields in one case.
Inline the
PDFDocument.prototype._parseHasJSActionsmethodThis code is short and simple enough that it can just be inlined in the
hasJSActionsgetter.Smaller diff with https://github.com/mozilla/pdf.js/pull/21841/changes?w=1