Skip to content

CTA links now use text underlines instead of borders (#490) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephaniehobson merged 1 commit into from
Oct 9, 2019
Merged

CTA links now use text underlines instead of borders (#490) #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## HEAD

* **css:** CTA links now use text underlines instead of borders (#490)

## 9.0.1

## Bug Fixes
Expand Down
22 changes: 0 additions & 22 deletions src/assets/sass/protocol/base/elements/_links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,29 +32,7 @@
.mzp-c-cta-link {
font-weight: bold;

&:link,
&:visited {
border-bottom: 2px solid;
color: $color-link;
text-decoration: none;
}

&:hover,
&:active,
&:focus {
@include transition(border-bottom-color 100ms ease-in-out);
border-bottom-color: transparent;
}

.mzp-t-firefox & {
@include font-firefox;
}

.mzp-t-dark & {
&:link,
&:visited {
color: $color-white;
text-decoration: none;
}
}
}
2 changes: 1 addition & 1 deletion src/assets/sass/protocol/components/_menu-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

.mzp-c-menu-list-title {
font-size: inherit;
font-weight: bold;

.mzp-t-mozilla .mzp-t-cta & {
@include font-firefox;
font-weight: bold;
}
}

Expand Down